Re: [Lilypond-auto] Issue 2689 in lilypond: Patch: Avoid duplication between slur and phrasing slur engravers.

[lilypond]

Comment #4 on issue 2689 by address@hidden: Patch: Avoid duplication  
between slur and phrasing slur engravers.
http://code.google.com/p/lilypond/issues/detail?id=2689

Implements inheritence in slur engravers to avoid code dups

http://codereview.appspot.com/7424049

Engraver inheritance has been implemented for some time with the ligature  
engravers.  The trick is to use the preprocessor for ADD_ACKNOWELDGER,  
ADD_END_ACKNOWLEDGER and ADD_TRANSLATOR in the actual engravers doing the  
lifting. All other preprocessing is fair game.

Passes regtests w/ no problems and no compiler warnings.

Sorry that this is bundled up with the break-slur stuff, but working on  
that patch got so annoying because of having to change stuff in both  
engravers that I got fed up and did the inheritance thing to save me time.

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings