[Lilypond-auto] Issue 3247 in lilypond: Patch: Prohibit non-postevents from music functions to be used as post-event

[lilypond]

Status: Started
Owner: ----
Labels: Type-Enhancement Patch-new

New issue 3247 by address@hidden: Patch: Prohibit non-postevents from music  
functions to be used as post-event
http://code.google.com/p/lilypond/issues/detail?id=3247

Prohibit non-postevents from music functions to be used as post-event

For example,

{ c-\mark \default }

produced an invalid music expression more or less indistinguishable from

{ \mark \default c }

Worse is that things like

{ c-\tweak color #red { g } }

also got accepted.  While \tweak (and other music functions) may
indeed return either post-events or straight music expressions, there
should be checks in place that the usage corresponds to its type.


Unfortunately, already make test turned up points of conflict
addressed by the following additional patch:

Make \balloonText into post-event, \balloonGrobText into proper event

This is a stopgap measure for getting some consistency into music
function use.  The real fix would be to convert \ballonText and
\balloonGrobText to the same kind of interface that \footnote uses.
Indeed, it might be saner to retire the whole AnnotateOutputEvent
folderol and instead just use footnotes without footnote-text.


With this patch set, make test succeeds here.  I would not be
particularly surprised, however, if the documentation compile turned
up further problems.  After all, the purpose of the patch is to flag
previously unnoticed sloppy code, and our documentation contains a lot
of code.

http://codereview.appspot.com/7866043

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings