|
From: | lilypond |
Subject: | Re: [Lilypond-auto] Issue 3322 in lilypond: Patch: Add callback factory grob::inherit-parent-property |
Date: | Sat, 20 Apr 2013 17:49:17 +0000 |
Updates:Labels: -Type-Enhancement -Patch-needs_work Type-Maintainability Patch-review
Comment #8 on issue 3322 by address@hidden: Patch: Add callback factory grob::inherit-parent-property
http://code.google.com/p/lilypond/issues/detail?id=3322Actually, I was about to push it rather than wait longer. If you are referring to <URL:https://codereview.appspot.com/8726045#msg6>: that proposes an _additional_ change to the name of a function not touched by this patch. Since that name is much less specific and much more hand-wavy, it is not an option to rather rename the name used in this patch into something resembling the preexisting function name.
So the question is one _starting_ from this patch, but definitely not _affecting_ this patch. Setting this one back to "Review". Short of any forthcoming feedback discouraging to push it, I'll push on my own responsibility in about a day.
It is not functionality-changing and basically a refactoring, so it does not actually need much of a feedback anyway.
--You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at: https://code.google.com/hosting/settings
[Prev in Thread] | Current Thread | [Next in Thread] |