Re: [Lilypond-auto] Issue 3330 in lilypond: bracketify-stencil moves grob's refpoint

[lilypond]

Comment #69 on issue 3330 by address@hidden: bracketify-stencil moves grob's  
refpoint
http://code.google.com/p/lilypond/issues/detail?id=3330

Ok, here is the problem analysis for  
input/regression/page-headers-and-footers.ly.  The spacing discrepancies  
appear with
commit c04c3256ab2b3b45a1a47de450dd12dccb6f1bc0
Author: David Kastrup <address@hidden>
Date:   Sat Apr 27 18:31:01 2013 +0200

    Let stack-lines deal properly with vertical spacing (X-empty stencils)

(which redefines stack-lines in terms of trivially calling  
ly:stencil-stack).  The passages resulting in different output are

  oddHeaderMarkup = \markup  {
    \override #'(baseline-skip . 1)
    \center-column {
      \box \fill-line { \teeny " " " " }
      \on-the-fly #first-page "first-page-header-text"
      \on-the-fly #not-first-page \fromproperty #'page:page-number-string
      \on-the-fly #(on-page 2) "page-2-header-text"
      \on-the-fly #last-page "last-page-header-text"
    }
  }

  evenHeaderMarkup = \oddHeaderMarkup

  oddFooterMarkup = \markup \fill-line {
    \override #'(baseline-skip . 0.5)
    \center-column {
        \on-the-fly #first-page "first-page-footer-text"
        \on-the-fly #last-page "last-page-footer-text"
        \on-the-fly #(on-page 2) "page-2-footer-text"
        \box \fill-line { \teeny " " " " }
    }
  }

The difference here is that the inactive \on-the-fly incantations take up  
space.  Some of that is compressed away by reducing the overall  
baselineskip, but that's not sufficient for creating a uniform appearance.   
_Before_ the patch is applied.

_After_ it is applied, the appearance is uniform: probably due to the  
reduced baselineskip everything is combined with a tight overall  
appearance.  Likely baselineskip is not relevant any more since using it  
would cause lines to overlap: I'll take a look what the result will be when  
removing the baselineskip override completely.  If that does not look nice,  
one might at least use a smaller value.

I think we can safely agree that the behavior of omitting the empty  
stencils caused by false on-the-fly incantations is not problematic.  Quite  
the opposite.  The current regtest source is an abomination that will only  
gain by not having to counterspace empty lines.

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings