Re: [Lilypond-auto] Issue 3553 in lilypond: Patch: Two fixes in Context::get_default_interpreter

[lilypond]

Updates:
        Status: Fixed
        Labels: -Type-Enhancement -Patch-push Type-Defect Fixed_2_17_27

Comment #5 on issue 3553 by address@hidden: Patch: Two fixes in  
Context::get_default_interpreter
http://code.google.com/p/lilypond/issues/detail?id=3553

Pushed to staging as
commit d7e9ab2f2782383025ffacd93a306f61f3ef7d45
Author: David Kastrup <address@hidden>
Date:   Thu Sep 12 22:05:07 2013 +0200

    Issue 3553/2: When creating a hierarchy above Bottom, all intermediate  
level
s are named "\new"

    Previously, get_default_interpreter gave all intermediate levels the
    same id as that of the new Bottom level.

    However, since issue 3225, there can be more than one Bottom in one
    hierarchy since a Bottom context (defined by not having a
    \defaultchild) can still have children contexts (of any type it
    \accepts even while it would not create them implicitly).

    So it is a bad idea to give implicitly created contexts the same id as
    any explicitly named context.

commit d756b5523a8d82491f734d79943314c5e6cd35b4
Author: David Kastrup <address@hidden>
Date:   Thu Sep 12 19:25:17 2013 +0200

    Issue 3553/1: get_default_interpreter should create contexts with  
missing co
ntext_id

    At the current point of time, an existing bottom context is returned
    even when there is a mismatch in ids.  For example, when writing

    \context Voice = "one" <<
      { \voiceOne g' g' g' g' }
      \context Voice = "two" { \voiceTwo c' c' c' c' }
    >>

    creates two voices, while

    \context Bottom = "one" <<
      { \voiceOne g' g' g' g' }
      \context Bottom = "two" { \voiceTwo c' c' c' c' }
    >>

    only uses a single Voice called "one".  This is arguably wrong.


--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings