|
From: | lilypond |
Subject: | Re: [Lilypond-auto] Issue 3606 in lilypond: preserve undocumented interface for LilyJAZZ |
Date: | Wed, 23 Oct 2013 11:07:50 +0000 |
Comment #13 on issue 3606 by address@hidden: preserve undocumented interface for LilyJAZZ
http://code.google.com/p/lilypond/issues/detail?id=3606Regarding comment #2: the patch is actually apparently created using git format-patch. Instead of git apply --index ... you are better off using git am ... on it since that retains the commit message and author/date information.
Which definitely is an advantage in workflow compared to our current manual not-really-procedures for applying single-commit reviews of people without git write access. What is called the "github way" in comment #3 does not overly convince me as one then reviews a branch rather than a patch set/series, and a branch might come from anywhere.
Conceptually, I like it better if the review is not inherently tied to a particular branch-off point.
--You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at: https://code.google.com/hosting/settings
[Prev in Thread] | Current Thread | [Next in Thread] |