Re: [Lilypond-auto] Issue 3705 in lilypond: Patch: Metafont code cleanup

[lilypond]

Updates:
        Owner: address@hidden
        Labels: -Patch-review Patch-new

Comment #7 on issue 3705 by address@hidden: Patch: Metafont code  
cleanup
http://code.google.com/p/lilypond/issues/detail?id=3705#c7

splitting file movement and whitespace-only changes into separate commits

the commits now read (in reverse chronological order):

unify formatting and indentation


----------------------------------------------------->8
include subfonts unconditionally


----------------------------------------------------->8
remove spurious else


----------------------------------------------------->8
make comments more uniform


----------------------------------------------------->8
factor out common inclusions and initializations


----------------------------------------------------->8
factor out autometric_parameter declarations


----------------------------------------------------->8
move brace-drawing procedure to separate file (and rename files)


----------------------------------------------------->8
rename feta-alphabet to feta-alphabet-generic

to conform to the convention

----------------------------------------------------->8
rename feta-generic to feta-other-generic; similarly parmesan-generic

these files are not for the whole font,
but just some glyphs that aren't in their own subfonts

----------------------------------------------------->8
remove feta-test-generic.mf and other testing files

they were just polluting the code

----------------------------------------------------->8
font: clean up staffline-display in testing mode

Previous testing code was a mix of hideous copy&paste with
non-obvious passing glyph outlines around, which attempted
to produce additional glyphs in testing mode, so that there
would be both on-staffline and on-staffspace variations.

That code was completely unreadable and unmaintainable.

Instead i've introduced a global variable that determines
how the stafflines will be printed relative to the glyphs.
To see alternative configuration, just change that value.

----------------------------------------------------->8
font: rename draw_staff to draw_staff_if_debugging

Previous name was confusing: the stafflines are actually
not drawn unless 'test' is set to non-zero value.

----------------------------------------------------->8
feta accidentals: split into several files


----------------------------------------------------->8
omit filename extension as in the rest of the file

http://codereview.appspot.com/42330044

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings