[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Lilypond-auto] Issue 3815 in lilypond: Patch: Parser: harmonize \ly
From: |
lilypond |
Subject: |
Re: [Lilypond-auto] Issue 3815 in lilypond: Patch: Parser: harmonize \lyricsto and \addlyrics arguments |
Date: |
Tue, 21 Jan 2014 12:32:39 +0000 |
Updates:
Status: Fixed
Labels: -Patch-push Fixed_2_19_2
Comment #12 on issue 3815 by address@hidden: Patch: Parser: harmonize
\lyricsto and \addlyrics arguments
http://code.google.com/p/lilypond/issues/detail?id=3815
Oh, I don't need a separate doc test _now_ that the countdown ended: I'll
just push to staging and let Patchy test. If it doesn't work, this will
need another review cycle. Pushed to staging as a merge commit (as it
includes uncompilable tests before running convert-ly):
* commit 809c04e37b8d3d368eda7e4b576e0d80d1934cc3
|\ Merge: 9d481c2 9fb28f4
| | Author: David Kastrup <address@hidden>
| | Date: Tue Jan 21 13:30:02 2014 +0100
| |
| | Merge branch 'issue3815' into staging
| |
| * commit 9fb28f4db2cf0f4d302f70c4def238cd2145f329
| | Author: David Kastrup <address@hidden>
| | Date: Tue Jan 21 13:27:45 2014 +0100
| |
| | Run scripts/auxiliar/update-with-convert-ly.sh
| |
| * commit 940767af99f39411e3e519a75968be11d47e3083
|/ Author: David Kastrup <address@hidden>
| Date: Thu Jan 16 11:25:23 2014 +0100
|
| Issue 3815: Parser: harmonize \lyricsto and \addlyrics arguments
|
| Previously, they allowed arbitrary music but since that required
looking
| at lookahead tokens in the wrong mode, it led to strange errors
like with
| lyr=\lyricsto A { }
| mus={c}
| when mus= was parsed as a single token in lyrics mode. Now both
\addlyrics
| and \lyricsto accept merely the same kind of delimited argument list
| that \lyrics or \chords accept. Additionally, to preserve
compatibility
| to a lot of examples, music identifiers like \mus are permitted as
the
| argument to \lyricsto and \addlyrics.
|
| Since this requires a change in existing uses, this includes a
| convert-ly rule that removes redundant uses of \lyricmode and
| rearranges the combination with context starters such that \lyricsto
| in general is applied last, like \lyricmode would be.
|
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
- Re: [Lilypond-auto] Issue 3815 in lilypond: Patch: Parser: harmonize \lyricsto and \addlyrics arguments, (continued)
- Re: [Lilypond-auto] Issue 3815 in lilypond: Patch: Parser: harmonize \lyricsto and \addlyrics arguments, lilypond, 2014/01/16
- Re: [Lilypond-auto] Issue 3815 in lilypond: Patch: Parser: harmonize \lyricsto and \addlyrics arguments, lilypond, 2014/01/16
- Re: [Lilypond-auto] Issue 3815 in lilypond: Patch: Parser: harmonize \lyricsto and \addlyrics arguments, lilypond, 2014/01/16
- Re: [Lilypond-auto] Issue 3815 in lilypond: Patch: Parser: harmonize \lyricsto and \addlyrics arguments, lilypond, 2014/01/16
- Re: [Lilypond-auto] Issue 3815 in lilypond: Patch: Parser: harmonize \lyricsto and \addlyrics arguments, lilypond, 2014/01/16
- Re: [Lilypond-auto] Issue 3815 in lilypond: Patch: Parser: harmonize \lyricsto and \addlyrics arguments, lilypond, 2014/01/16
- Re: [Lilypond-auto] Issue 3815 in lilypond: Patch: Parser: harmonize \lyricsto and \addlyrics arguments, lilypond, 2014/01/16
- Re: [Lilypond-auto] Issue 3815 in lilypond: Patch: Parser: harmonize \lyricsto and \addlyrics arguments, lilypond, 2014/01/16
- Re: [Lilypond-auto] Issue 3815 in lilypond: Patch: Parser: harmonize \lyricsto and \addlyrics arguments, lilypond, 2014/01/18
- Re: [Lilypond-auto] Issue 3815 in lilypond: Patch: Parser: harmonize \lyricsto and \addlyrics arguments, lilypond, 2014/01/21
- Re: [Lilypond-auto] Issue 3815 in lilypond: Patch: Parser: harmonize \lyricsto and \addlyrics arguments,
lilypond <=