[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4899 Reorganize listener/acknowledger initialization

[Auto mailings of changes to Lily Issues]

• status: Fixed --> Verified

---

[issues:#4899] Reorganize listener/acknowledger initialization

Status: Verified
Labels: Fixed_2_19_45
Created: Sat Jun 18, 2016 11:55 AM UTC by David Kastrup
Last Updated: Thu Jun 23, 2016 09:16 AM UTC
Owner: David Kastrup

Reorganize listener/acknowledger initialization

This reverts most of the changes of issue 4885 in order to arrive at
listeners/acknowledgers that can be kept private or protected
according to the actual use cases in engravers and other translators.
It also streamlines some of the other code. Contains the following
commits in reverse order (all separately tested to compile):

Remove {Translator,Engraver}::ack_find_base

The indirection and complication added by it does not really
help in any manner.

Remove Translator::method-find_base

It's basically a trivial replacement and confuses more than it helps.

Listeners should not be virtual

Gregorian_ligature_engraver::listen_pes_or_flexa and
Ligature_engraver::listen_pes_or_flexa were accidentally
declared virtual, but their registration already caters
for what amounts to virtual overrides in effect.

Revert "Issue 4885/2: Let ADD_ACKNOWLEDGER state actual classes"

This reverts commit 7c36dbb1834c7c68e4b94777241de3ea02971aca.

Revert "Issue 4885/3: Remove ack_finder/ack_find_base"

This reverts commit b9040afd1dcfbee6b45bc3d54850ff50d51c8ee9.

Let method_finder also find listeners

This allows using inherited listeners directly like with
acknowledgers and translator methods.

http://codereview.appspot.com/301980043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto