[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #4938 Refactor handling of supported MIDI control changes

[Auto mailings of changes to Lily Issues]

The code changes for this issue comprise three patches, which should preferably be committed separately to best preserve the incremental nature of the changes. (I've tested that the code still compiles after each individual patch.) Thanks in advance for your help with pushing these.

(Fortunately, these changes are the last ones that I currently have in my queue except for Issue 4920, with which, I think, I'm going to wait until the implementation stabilizes since during the review some other developers voiced their intentions to make code changes which could alter the behavior from what is currently documented in the patch issue.)

---

[issues:#4938] Refactor handling of supported MIDI control changes

Status: Started
Created: Wed Jul 20, 2016 05:31 PM UTC by H T LilyPond
Last Updated: Wed Jul 27, 2016 07:36 AM UTC
Owner: H T LilyPond

This issue separates the code refactoring originally done for Issue 4745 from the enhancements implemented as part of that issue. This patch does not change any existing functionality (nor introduce any new features), its purpose is to only improve the maintainability of the current implementation by simplifying the interfaces, removing duplication of code, and cleaning up some terminology.

(Background: Issue 4745 is about the ability to annotate arbitrary MIDI CCs in LilyPond input. That issue still remains open due to still unresolved design questions raised during the review about the proper syntax and implementation for the annotations. Regardless of the eventual fate of the enhancement, I'd hate to see this code refactoring being lost, however, so that's why the current issue was created.)

http://codereview.appspot.com/309720043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto