[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5033 LyricHyp

From:

Auto mailings of changes to Lily Issues

Subject:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5033 LyricHyphen whiteout

Date:

Sat, 04 Mar 2017 20:12:38 +0000

status: New --> Started
Patch: --> review
Type: Patch --> Enhancement
Comment:

Passes make, make check and a full make doc.

[issues:#5033] LyricHyphen whiteout

Status: Started
Created: Mon Jan 16, 2017 01:13 PM UTC by Knut Petersen
Last Updated: Sat Mar 04, 2017 06:12 PM UTC
Owner: Knut Petersen
Attachments:

0001-Special-whiteout-code-for-the-LyricHyphen-grob.patch (4.0 kB; text/x-patch)
WhiteoutEvenBetter-A.jpg (39.7 kB; image/jpeg)
WhiteoutEvenBetter-B.jpg (23.0 kB; image/jpeg)
WhiteoutImproved.jpg (42.6 kB; image/jpeg)
WhiteoutOrig.jpg (47.6 kB; image/jpeg)

http://codereview.appspot.com/312530043 (Rietveld for attached patch)

Whiteout for LyricHyphen grobs is seldom used - obviously the hyphen must not whiteout parts of the lyric syllables. But it is a vital feature if mensuration lines are used (old music, Distler, ...)

A proper outline whiteout would be ideal, but it is not implemented ... the current code fails because you need a relatively large whiteout area for a small object. A brute force fix is to increase the number of iterations, but the result would be a pdf with a high percentage of whiteout code.

And there is the case where a long melisma produces a single hyphen event that generates a lot of hyphens that cross a number of mensuration lines. Rectangular or roundedbox whiteout will produce gaps in all mensuration lines crossed, even if there is no collision. That's not acceptable.

Attached is a patch that solves the problem. It passes a full make, and make check does not identify any problem.

WhiteoutOrig.jpg: Current code

WhiteoutImproved.jpg: Brute-force-fix - more than 90% whiteout code in the pdf

WhiteoutEvenBetter-X.jpg: Proposed behaviour as implemented in the attached patch

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot