[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5077 buil

From:

Auto mailings of changes to Lily Issues

Subject:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5077 build fail on GNU Hurd because of PATH_MAX

Date:

Sat, 11 Mar 2017 12:06:52 +0000

I've created new Rietveld issue.
Thank you.

[issues:#5077] build fail on GNU Hurd because of PATH_MAX

Status: Started
Created: Wed Feb 22, 2017 01:06 PM UTC by Federico Bruni
Last Updated: Sat Mar 11, 2017 12:02 PM UTC
Owner: pkx166h
Attachments:

hurd_file_name_support.patch (1.6 kB; text/x-patch)

http://codereview.appspot.com/319400043

Report: http://lists.gnu.org/archive/html/bug-lilypond/2017-01/msg00023.html

LilyPond failed to build on GNU Hurd because Hurd does not have PATH_MAX.
Fortunately, a workaround is available thanks to the combined effort of
Debian developers Don Armstrong (Debian package maintainer for LilyPond)
and Petter Reinholdtsen (Debian Hurd guru).

Petter expressed his wish to send this patch upstream to be included in
future releases of LilyPond, hence this bug report with the attached patch!
:-)

A little bit of history:

2013-05-13, Don Armstrong <don AT="" debian.org="">:

Changelog for LilyPond Debian package version 2.16.2-2:

Patch around using PATH_MAX in flower/file-name.cc to have builds work
on hurd (hopefully).

2014-09-10, Petter Reinholdtsen <pere AT="" hungry.com="">, <pere AT="" debian.org="">:

https://bugs.debian.org/761036

Hi. The lilypond package do not build on hurd, even with a hurd patch
in place. The cause seem to be a typo in the file
debian/patches/hurd_file_name_support, checking for GNU_SOURCE
instead of _GNU_SOURCE (at least that is what the getcwd() manual page
claim to look for).

Attached is an updated patch, fixing that bug, a memory leak
forgetting to release the memory allocated by get_current_dir_name(),
and adding the same code in the test code.

Please replace the patch in the current source with this new one, and
consider sending it upstream. :)

2016-07-18, Dr. Tobias Quathamer <toddy AT="" debian.org="">:

Reviewed and committed the patch to the debian-experimental branch
(intended for an experiment with LilyPond 2.19.x and Guile-2.x)
in the LilyPond deb packaging git repository:

https://anonscm.debian.org/git/collab-maint/lilypond.git/commit/?h=debian-experimental&id=e56df084666dbf9905d90c062b1f462aeb6f5f4a

2017-01-27, me:

Discovered the above, and cherry-picked Dr. Tobias's commit onto the
"debian" (stable) branch with 2.18.2.

Many thanks!

Anthony
foka AT debian.org

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------ Announcing the Oxford Dictionaries API! The API offers world-renowned dictionary content that is easy and intuitive to access. Sign up for an account today to start using our lexical data to power your apps and projects. Get started today and enter our developer competition. http://sdm.link/oxford