[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5220 Let

From:

Auto mailings of changes to Lily Issues via Testlilyissues-auto

Subject:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5220 Let repeatTie work inside of event-chord

Date:

Sun, 22 Oct 2017 20:04:44 +0000

Wouldn't it make sense to make parenthesizing LaissezVibrerTie work as well?

Further testings showed that parenthesizing LaissezVibrerTie doesn't work because 'parenthesize-elements' from output-lib.scm sees LaissezVibrerTieColumn and tries to parenthesize it.
A check for (interval-sane? x-ext) and putting out point-stencil if false cures the problem, and makes the patch work, as far as I can tell right now. Parenthesizing LaissezVibrerTie then works as well.
Here the full code for 'parenthesize-elements':

(define (parenthesize-elements grob . rest)
  (let* ((refp (if (null? rest)
                   grob
                   (car rest)))
         (elts (ly:grob-array->list (ly:grob-object grob 'elements)))
         (get-friends
           (lambda (g)
             (let ((syms (ly:grob-property g 'parenthesis-friends '()))
                   (get-friend (lambda (s)
                                 (let ((f (ly:grob-object g s)))
                                   (cond
                                     ((ly:grob? f) (list f))
                                     ((ly:grob-array? f) (ly:grob-array->list f))
                                     (else '()))))))
               (apply append (map get-friend syms)))))
         (friends (apply append elts (map get-friends elts)))
         (x-ext (ly:relative-group-extent friends refp X))
         (stencils (ly:grob-property grob 'stencils))
         (lp (car stencils))
         (rp (cadr stencils))
         (padding (ly:grob-property grob 'padding 0.1)))
    (if (interval-sane? x-ext)
        (ly:stencil-add
         (ly:stencil-translate-axis lp (- (car x-ext) padding) X)
         (ly:stencil-translate-axis rp (+ (cdr x-ext) padding) X))
        point-stencil)))

Not sure whether this is the right fix, though.
Better 'parenthesize-elements' wouldn't ever see LaissezVibrerTieColumn.
Thoughts?

[issues:#5220] Let repeatTie work inside of event-chord

Status: Started
Created: Sat Oct 21, 2017 04:11 PM UTC by Thomas Morley
Last Updated: Sun Oct 22, 2017 11:41 AM UTC
Owner: Thomas Morley
Attachments:

repeatTie-with-patch.png (16.3 kB; image/png)
repeatTie-without-patch.png (15.7 kB; image/png)

Let repeatTie work inside of event-chord

The previous coding of repeat-tie-engraver.cc is replaced by the
renamed coding of the laissez-vibrer-engraver.

http://codereview.appspot.com/335910043

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot