[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5319 Make sky

From:

Auto mailings of changes to Lily Issues via Testlilyissues-auto

Subject:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5319 Make skylines reflect grob rotation

Date:

Sat, 12 May 2018 11:27:34 -0000

labels: --> Fixed_2_20_0
status: Started --> Fixed
Patch: push -->
Comment:

Thank you Torsten,

author  Torsten Hämmerle <address@hidden> 
    Fri, 20 Apr 2018 14:59:15 +0100 (15:59 +0200)
committer   James Lowe <address@hidden> 
    Sat, 12 May 2018 12:26:27 +0100 (12:26 +0100)
commit  72e9c4c6c313a15f934b58e00cceabc71503b06d

[issues:#5319] Make skylines reflect grob rotation

Status: Fixed
Labels: Fixed_2_20_0
Created: Thu May 03, 2018 11:44 AM UTC by Torsten Hämmerle
Last Updated: Thu May 10, 2018 10:21 AM UTC
Owner: Torsten Hämmerle
Attachments:

skyline-grob-rotation.png (59.4 kB; image/png)

http://codereview.appspot.com/342060043

As has been agreed in thread http://lilypond.1069038.n5.nabble.com/Skylines-and-certain-grob-properties-rotation-extra-offset-tt212002.html, skylines should reflect the grobs' "rotation" property.

The "rotation" property (grob-interface) will be applied to the stencil after skylines have been built. Therefore, the skylines currently do not know about grob rotation and stoically stay in place.

In the example PNG file, you can see the original skylines on the left compared to the enhanced skylines on the right:

Hairpins now actually get "out of the way" when being rotated (vertical skylines)
Note the distance of the hairpin to the stave: padding is respected due to more realistic skylines.
TextScripts now align as they should
Accidentals: The two sharps now will be placed directly above and below one another because they take up less vertical space when rotated (horizontal skylines)

All the best,
Torsten

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot