[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5320 beam.cc: avoid calculating an invalid reference

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

• labels: --> Fixed_2_21_0
• status: Started --> Fixed
• Patch: push -->
• Type: Enhancement --> Crash
• Comment:

Pushed to staging as
commit d63756608d265d7a99444af1123b7be8a06f3cc2
Author: David Kastrup address@hidden
Date: Wed May 9 13:48:35 2018 +0200

Issue 5320: beam.cc: avoid calculating an invalid reference

In calc_beam_segments, an invalid reference to a neighboring segment
was calculated (and not used) at the extreme ends of the beam.  This
caused segfaults on Fedora.  Since the reference is used at most twice
anyway and in the same _expression_, it seems easier to just use the
_expression_ directly (the invalid cases are then skipped due to
short-circuit evaluation).

---

[issues:#5320] beam.cc: avoid calculating an invalid reference

Status: Fixed
Labels: Fixed_2_21_0
Created: Wed May 09, 2018 11:49 AM UTC by David Kastrup
Last Updated: Thu May 17, 2018 08:09 AM UTC
Owner: David Kastrup

beam.cc: avoid calculating an invalid reference

In calc_beam_segments, an invalid reference to a neighboring segment
was calculated (and not used) at the extreme ends of the beam. This
caused segfaults on Fedora. Since the reference is used at most twice
anyway and in the same _expression_, it seems easier to just use the
_expression_ directly (the invalid cases are then skipped due to
short-circuit evaluation).

http://codereview.appspot.com/343160043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto