[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5391 Prob::eq

labels: --> Fixed_2_21_0
status: Started --> Fixed
Patch: push -->
Type: Enhancement --> Defect
Comment:

Pushed to staging as
commit 5e185a918d2a7e1eade9a2aa1fe40ba03f187f63
Author: David Kastrup address@hidden
Date: Thu Jul 26 16:02:22 2018 +0200

Issue 5391/2: Don't set origin on copied music explicitly

There would be some mild incentive if the origin were accessed an
inordinary amount of times (and thus leaving it unset would maximize
access times to it) but there is no evidence for that.  One reason
might be to ensure greater structural similarity between copies of
music, but Prob::equal_p has been changed to be robust against
differences here.

commit 7fc5445eb041aef1974296dff7fe77502492418f
Author: David Kastrup address@hidden
Date: Thu Jul 26 16:10:13 2018 +0200

Issue 5391/1: Prob::equal_p: discard "origin" property

Previously elements of class Input were considered equal when compared
as part of Music property lists but this did not take into account
that some music might store its origin (if any) at different locations
in its property lists.  So we just discard any "origin" property
completely, regardless of position in the property list and its actual
value type.

[issues:#5391] Prob::equal_p: discard "origin" property

Status: Fixed
Labels: Fixed_2_21_0
Created: Thu Jul 26, 2018 02:31 PM UTC by David Kastrup
Last Updated: Wed Aug 01, 2018 10:29 AM UTC
Owner: David Kastrup

Prob::equal_p: discard "origin" property

Previously elements of class Input was considered equal when compared
as part of Music property lists but this did not take into account
that some music might store its origin (if any) at different locations
in its property lists. So we just discard any "origin" property
completely, regardless of position in the property list and its actual
value type.

Also contains commit:

Don't set origin on copied music explicitly

There would be some mild incentive if the origin were accessed an
inordinary amount of times (and thus leaving it unset would maximize
access times to it) but there is no evidence for that. One reason
might be to ensure greater structural similarity between copies of
music, but Prob::equal_p has been changed to be robust against
differences here.

http://codereview.appspot.com/363740043

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

From:	Auto mailings of changes to Lily Issues via Testlilyissues-auto
Subject:	[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5391 Prob::equal_p: discard "origin" property
Date:	Wed, 01 Aug 2018 18:51:17 -0000