[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5449 Chor

Hi James,
that’s odd; after your first report I’ve tested it with an entirely new git clone (just retested it now), and it builds without a hitch. legacy.itely is supposed to be generated from legacy-intro.itely, and that’s what happens here:

address@hidden:/tmp/lilypond$ find -name legacy*
./Documentation/out/legacy.texi
./Documentation/out/legacy.itely
./Documentation/snippets/legacy.snippet-list
./Documentation/snippets/legacy-intro.itely

What surprises me is that legacy-code.itely shouldn’t be present here (I used that name in the first patch set, but then shortened it to just legacy.itely).
Have you tested the latest patch set? For example you can do

$ wget https://codereview.appspot.com/download/issue363880043_40001.diff 
$ git apply issue363880043_40001.diff ; rm issue363880043_40001.diff
$ make ; make doc

on a pristine branch.

[issues:#5449] Chord names clean-up; no more Banter, exceptionsPartial or \powerChords.

Status: Started
Created: Mon Dec 17, 2018 05:23 PM UTC by Valentin Villenave
Last Updated: Thu Dec 20, 2018 03:22 PM UTC
Owner: Valentin Villenave

Chord names clean-up; no more Banter, exceptionsPartial or \powerChords.

This rather large patch

removes the legacy code for unsupported non-Ignatzek chord names;
that code hasn’t been working properly for nearly 15 years anyway, see
https://lists.gnu.org/archive/html/lilypond-user/2008-08/msg00288.html
stores a version of this code, with minor corrections, as a
self-contained snippet (for historical purposes mainly), both
on the LSR (as an upgrade to snippet #102) and in a dedicated
subsection of the Snippets doc page.
as a result, chord-generic-names.scm is no longer found in scm/
and the chord-names-jazz.ly doc chart no longer includes any
alternative chord naming systems (that were already broken anyway).
chordNamesExceptionsFull and chordNamesExceptionsPartial
properties have been removed as well (both having no longer had
any effect whatsoever for quite some time).
the main (and now only) chordNamesExceptions property def
has been slightly updated for slightly neater glyphs and spacing,
and so as to now include power chords by default; as a result,
\powerChords is no longer needed, thereby solving any possible
confusion with \germanChords and the like. (I can’t think of any
case where users would explicitely type \chords{c:5} in order to
get the same output as \chords{c} -- can you?)
the documentation has been updated as well; convert rules
have been added (although these may be merged with previous
2.21.0 rules once the release cycle gets back on track).

http://codereview.appspot.com/363880043

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

From:	Auto mailings of changes to Lily Issues via Testlilyissues-auto
Subject:	[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5449 Chord names clean-up; no more Banter, exceptionsPartial or \powerChords.
Date:	Thu, 20 Dec 2018 21:14:40 -0000