|
| From: | Auto mailings of changes to Lily Issues via Testlilyissues-auto |
| Subject: | [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5217 random results for the merge-rests-engraver regression test |
| Date: | Mon, 11 Nov 2019 15:29:04 -0000 |
pushed to staging as
commit 152a28103106cbe6556c40dc40a544cf8bd94136 Author: Jonas Hahnfeld <address@hidden> Date: Tue Nov 5 17:54:41 2019 +0100 Issue 5217: Fix sorting order without outside-staff-priority If the two Grobs have no outside-staff-priority, the compare function staff_priority_less() would relate the two pointers. This may lead to changing sorting orders in subsequent runs, apparently resulting in "random" positions in the regression tests rest-dot-position.ly and sometimes merge-rests-engraver.ly. Solve this by keeping the original order in the vector: * Mark two Grobs without outside-staff-priority as being equal by always returning false (none is less than the other), and * use vector_stable_sort() to keep equal items in their relation.
Please let me know if you're still having issues with the two mentioned regression tests after creating a new test-baseline.
[issues:#5217] random results for the merge-rests-engraver regression test
Status: Fixed
Labels: Fixed_2_21_0
Created: Fri Oct 20, 2017 07:28 AM UTC by Knut Petersen
Last Updated: Mon Nov 11, 2019 01:55 PM UTC
Owner: Jonas Hahnfeld
Attachments:
There is some randomness in the placement of dots. The merge-rests-engraver.ly regtest (git-version557dc7) exposes the problem as the output might be one of the two attached pngs. The probability for both results is identical on my system.
Update Nov 5th 2019
Issue 5217: Fix sorting order without outside-staff-priority
If the two Grobs have no outside-staff-priority, the compare function
staff_priority_less() would relate the two pointers. This may lead to
changing sorting orders in subsequent runs, apparently resulting in
"random" positions in the regression tests rest-dot-position.ly and
sometimes merge-rests-engraver.ly.
Solve this by keeping the original order in the vector:
Mark two Grobs without outside-staff-priority as being equal by
always returning false (none is less than the other), and
use vector_stable_sort() to keep equal items in their relation.
http://codereview.appspot.com/554960043
Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
_______________________________________________ Testlilyissues-auto mailing list address@hidden https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
| [Prev in Thread] | Current Thread | [Next in Thread] |
