[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5646 Swit

From:

Auto mailings of changes to Lily Issues via Testlilyissues-auto

Subject:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5646 Switch to Python 3.x

Date:

Wed, 22 Jan 2020 14:28:28 -0000

Am Mittwoch, den 22.01.2020, 14:00 +0000 schrieb David Kastrup:

"Jonas Hahnfeld" address@hidden writes:

(apparently I can't reply via email, so copy-pasting here)

Am Mittwoch, den 22.01.2020, 13:03 +0000 schrieb David Kastrup:

"Jonas Hahnfeld" address@hidden writes:

David, did you even carefully read my response?!? I'm doing exactly
that!

No, you aren't. They are not supposed to be 3 separate Rietveld issues
but a single issue with 2 updates to it.

This means it will be impossible to update the individual commits.

Indeed. But the fixes on top tend to be small.

Usually yes. But in this scenario I might be forced to re-run 2to3 in the middle of the series if somebody commits a change to any of the touched python files in the mean time.

[...]
It's one use case of Reitveld-based review where our current setup does
not provide a satisfactory workflow.

+1, sadly. On the positive side, this kind of changes with incompatible dependency versions are hopefully rare enough.

[...]

So $ git bisect might pick up an intermediate commit (3dc88bc7db to
703dca1fd6) and ask you to test it. This might work in your example,
but actually not for switching to Python 3.x for the mentioned reasons.

In my experience, Git travels into non-mainline branches only if it "has
to". I have yet to land in one such side branch, but maybe I have just
been lucky.

Apparently the latter. Not really related to this issue, but I hit this with a constructed example on my first try. In the attached repo,

 $ git bisect start
 $ git bisect bad
 $ git bisect good fd7f669
Bisecting: 2 revisions left to test after this (roughly 1 step)
[90f9202f1a0f49349895ac0118776b55e4b642c2] c

which is the first commit on branch 'issue' :-(

Attachments:

test.tar.gz (10.8 kB; application/gzip)

[issues:#5646] Switch to Python 3.x

Status: Started
Created: Thu Dec 19, 2019 06:15 PM UTC by Jonas Hahnfeld
Last Updated: Wed Jan 22, 2020 01:44 PM UTC
Owner: Jonas Hahnfeld

Switch to Python 3.x

Find and require at least Python 3.5 which will allow us to address
some deprecation warnings, most notably about the 'imp' module.
The major version 3.5 was first released in September 2015 and should
be available in all major distributions, including Ubuntu LTS 16.04 and
18.04 as well as CentOS/RHEL 7.x and 8.x.

Invidivial changes:
https://codereview.appspot.com/545370043
https://codereview.appspot.com/573340043
https://codereview.appspot.com/561270043

Full patch (with Patch Sets)
https://codereview.appspot.com/553420043

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.