[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5729 Fix SyntaxWarning's

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

---

[issues:#5729] Fix SyntaxWarning's

Status: Started
Created: Sun Feb 02, 2020 02:52 PM UTC by Jonas Hahnfeld
Last Updated: Sun Feb 02, 2020 02:52 PM UTC
Owner: nobody

Fix SyntaxWarning's

Individual changes:
1) abc2ly: Fix SyntaxWarning

This line still works in Python 3.8, but it throws a warning:

SyntaxWarning: "is" with a literal. Did you mean "=="?

2) musicxml2ly: Remove drummode

This code is fundamentally broken: NoteEvent::ly_expression() and
NoteEvent::chord_element_ly() miss a '%' to format the string. Instead
the code "calls" the string which Python meets with a SyntaxWarning.

Trying to hit this code path, musicxml only sets the drum_type attribute
in Note::initialize_drum_event() called from Note::to_lily_object().
However as far as I understand the MusicXML specification, a <note>
must always have either a <pitch>, or <unpitched>, or <rest>.
If I try to construct an (invalid) input with only an instrument name,
musicxml2ly breaks at another function, so this is really dead code.</rest></unpitched></pitch></note>

http://codereview.appspot.com/559440043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto