[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5734 Fix conv

From:

Auto mailings of changes to Lily Issues via Testlilyissues-auto

Subject:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5734 Fix convert-ly with Python 3

Date:

Thu, 06 Feb 2020 11:28:15 -0000

labels: --> Fixed_2_21_0
status: Started --> Fixed
Patch: countdown -->
Comment:

Skipping countdown - as David correctly notices:
> from "doesn't work" there cannot be much more of a regression to be afraid of.

commit e76d6918c3c5704de3ed90c58340cd804f79439e
Author:     Jonas Hahnfeld &lt;hahnjo@hahnjo.de&gt;
AuthorDate: Tue Feb 4 19:58:06 2020 +0100
Commit:     Jonas Hahnfeld &lt;hahnjo@hahnjo.de&gt;
CommitDate: Thu Feb 6 12:03:34 2020 +0100

    Issue 5734: Fix convert-ly with Python 3

    The error was &#34;&#39;str&#39; object has no attribute &#39;decode&#39;&#34;, so it already
    is decoded. The encoding seems to also be correct, as filenames with
    Unicode characters work just fine.
    It&#39;s worrying that none of the usual testing commands seem to invoke
    the script with a real input file, only the output of --help is used.

[issues:#5734] Fix convert-ly with Python 3

Status: Fixed
Labels: Fixed_2_21_0
Created: Tue Feb 04, 2020 07:26 PM UTC by Jonas Hahnfeld
Last Updated: Thu Feb 06, 2020 06:28 AM UTC
Owner: Jonas Hahnfeld

Fix convert-ly with Python 3

The error was "'str' object has no attribute 'decode'", so it already
is decoded. The encoding seems to also be correct, as filenames with
Unicode characters work just fine.
It's worrying that none of the usual testing commands seem to invoke
the script with a real input file, only the output of --help is used.

If possible I'd like to push this as soon as possible. The normal process
fails on convert-ly anyhow...

http://codereview.appspot.com/555260044

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.