[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5773 Quarter Tones for all Languages incl. MusicXML import

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

Hello James,

I noticed Werner's comment but wanted to wait for other hints.

Question: It is a merely cosmedic change in scm/define-note-names.scm (inserting spaces between the elements of a list):

  '((català catalan) (español espanol) (português portugues)))

instead of

  '((català catalan)(español espanol)(português portugues)))

Do I need to upload a new patch to Rietveld, probably causing an unnecessary make, make check and make full doc run, or is it possible just to implement it in my patch for pushing (formatted against current master) later on?

I'll do whatever you consider appropriate and then add a corresponding reply to Rietveld.

Thanks,
Torsten

---

[issues:#5773] Quarter Tones for all Languages incl. MusicXML import

Status: Started
Created: Tue Feb 18, 2020 01:12 PM UTC by Torsten Hämmerle
Last Updated: Sat Feb 22, 2020 10:05 AM UTC
Owner: Torsten Hämmerle
Attachments:

• all-accidentals.pdf (46.4 kB; application/pdf)

https://codereview.appspot.com/577520043

Missing note name definitions

Quarter tone pitches had not yet been defined for some input languages.
Missing quarter tone definitions added.
And language names containing special characters now have been switched to their proper spelling (as it has already been the case for español and français). Now, there's català and protuguês, too.
The original spellings have been kept as an alternative resp. for reasons of compatibility.

File scm/define-note-names.scm

• nederlands: was OK
• català: proper spelling, quarter tones added, (catalan kept for compatibility)
  qb, tqb: "quart de to", "tres quarts de to" bemoll
  qd, tqb: "quart de to", "tres quarts de to" diesi
  qs, tqs: "quart de to", "tres quarts de to" sostingut
• deutsch: was OK
• english: was OK
• español: main definition renamed, espanol still as an alternative
• français: was OK
• italiano: was OK
• norsk: quarter tones added
  Dutch/German nomenclature (-ih/-eh)
• português: proper spelling (portugues kept for compatibility)
• suomi: quarter tones added
  Dutch/German nomenclature (-ih/-eh)
• svenska: quarter tones added
  Dutch/German nomenclature (-ih/-eh)
• vlaams: quarter tones added
  solfège with language specific suffixes: hb, hk: "halve bemol", "halve kruis" etc.
• arabic: a case of its own, unchanged

Documentation (Notation Reference)

Files Documentation/*/notation/pitches.itely

• "Note names in other languages": tables updated and unified in all languages
• Complete set of quarter tones in all languages
• remarks about quarter tones missing from some languages removed
• All existing pitches.itely files updated (en, ca, de, es, fr, it, ja)

MusicXML import

File scripts/musicxml2ly.py

Map command line language option w/o special characters to proper names.
As a desired side effect, invoking musixml2ly with the old language names, the LilyPond file will be created using the language specific proper names:
catalan/catala -> català
espanol -> español
francais -> français
portugues -> português

File python/musicexp.py

• language definitions incidentally sorted in common lilypond order
• pitch_general: there are no short forms for quarter tones in Dutch! Quarter tone import for LilyPond's mother tonguedid not work! eeh/aeh resp. eeseh/aeseh must remain untouched!
• pitch_nederlands: uses pitch_general
• pitch_catalan: italian note names did not work, proper definition added
• pitch_deutsch: use common special forms eh, ah, asas, asah, etc.
• pitch_english: was OK
• pitch_espanol: was OK
• pitch_francais: was OK
• pitch_italiano: was OK
• pitch_norsk: current deutsch did not fit anymore, special norsk definition added
• pitch_portugues: was OK
• pitch_suomi: was completely missing
• pitch_svenska: quarter tone import added and wrong bess (->hessess) corrected
• pitch_vlaams: quarter-tone import added

Tests performed

MusicXML file (created by Musescore 3..4.2) containing a full set of notes ranging from ceses to bisis in quarter-tone steps has been imported for all languages (except Arabic).
That way, it is easy to check that all the pitch definitions are there (and correct), at the same time ensuring that musicxml2ly does not contain any erroneous or missing pitch conversions.

Attachment: Just oneMusicXML import examle (vlaams in this case) showing all the pitches. The empty bars are reseverd for extended triple-flat/sharp range.

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto