[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5824 output-distance cleanup

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

• summary: output-distance refactor --> output-distance cleanup
• Comment:

commit 37c6ba676f4722a4e5a7b9965b64d46eff5e0bb1 (output-distance-test)
Author: Han-Wen Nienhuys <address@hidden>
Date: Fri Mar 6 16:47:26 2020 +0100

Fix test target name in python/GNUmakefile

commit 79a1f4de2ac6035bbedf0e49841581d21533d3b7
Author: Han-Wen Nienhuys <address@hidden>
Date: Fri Mar 6 16:32:12 2020 +0100

scripts/build: run self-test as part of 'check' suite.

commit 613d8478797784ecc9e7676639375e7f18d4abf1
Author: Han-Wen Nienhuys <address@hidden>
Date: Fri Mar 6 16:30:23 2020 +0100

output-distance: avoid calling strip() on None

commit 80079c73090bdd7608567c76508bc1c9f1c83d33
Author: Han-Wen Nienhuys <address@hidden>
Date: Fri Mar 6 11:54:12 2020 +0100

output-distance: make self test pass again:

* Remove --create-images option. This is always true.

* Remove --no-compare-images option. We always compare.

* Drop dynamic table headings. before/after also works

* Use same options as regtest in self-test.

* Check that .pngs/.jpgs are created.

commit 973677710c4f7b4551a0283f1084dfa68c4357d0
Author: Han-Wen Nienhuys <address@hidden>
Date: Fri Mar 6 11:53:53 2020 +0100

output-distance: remove support for stencil _expression_ checks

This must have been broken since commit c1a4e44 "don't do _expression_
comparison." (Jun 2007).

This also caused a self-test failure in output-distance, which means
it hasn't been run for 13 years.

Adapt for _expression_/origin removal.  Make test_compare_signatures pass,

commit 1918da8bd677dd7ec2efd4bc1280002d20a65fce
Author: Han-Wen Nienhuys <address@hidden>
Date: Fri Mar 6 10:40:27 2020 +0100

output-distance: cleanups

* Centralize imports at top

* Use doc strings rather than comments

* Add more comments/docstrings

* Remove unused GrobSignature.origin

* Clarify method names:

* snippet_fn_re as TextFileCompareLink instance variable

* use time.time() rather than time.clock()

* use log_verbose() rather than print()

* set the actual centroid in GrobSignature.

* remove unused axis_centroid() method

---

[issues:#5824] output-distance cleanup

Status: Started
Created: Fri Mar 06, 2020 04:13 PM UTC by Han-Wen Nienhuys
Last Updated: Sat Mar 07, 2020 02:43 AM UTC
Owner: Han-Wen Nienhuys

https://codereview.appspot.com/581770043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto