[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5829 Re-indent all mf files

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

Applied to staging as
commit c9debce76a75ab4c5d81fa96e2ac5f45615803b3
Author: Torsten Hämmerle address@hidden
Date: Sat Mar 7 08:42:48 2020 +0100

Issue 5829: Re-indent all mf files

As a second step after having replaced all tabs by 8 character indentations,
these indentations will now be reduced to 2 characters.

"Tabs are used..." passage removed from
Contributor's Guide 13.6 METAFONT formatting rules.

---

[issues:#5829] Re-indent all mf files

Status: Fixed
Labels: Fixed_2_21_0
Created: Sat Mar 07, 2020 09:22 AM UTC by Torsten Hämmerle
Last Updated: Wed Mar 11, 2020 07:41 AM UTC
Owner: Torsten Hämmerle

https://codereview.appspot.com/573610048

Now that Werner has banned all tabs from mf files, initially replacing them by 8 spaces each, it's time for the second step:

lemzwerg 2020/02=29 17:23:39
We could later decide to reduce the indentation to two (or four) spaces – which I like much better. However, this would be a lot of work and is probably not worth the trouble.

Design question: 2 or 4 character-indent?

1. Applying a general indent of 2 or 4 characters to mf files will be less wasteful and better matches the usual 2 or 4 character indent used throughout.
2. having saved quite a lot of space, ident fet_begingroup [...] fet_endgroup, too?

Examples for Question 2:

mf/accidentals.mf (current) already used indentation for fet_begringroup [...] fet_endgroup`

fet_begingroup ("accidentals");
        input feta-arrow;
        input feta-sharps;
        input feta-naturals;
        input feta-flats;
        input feta-parenthesis;
fet_endgroup ("accidentals");

mf/accidentals.mf (new) (reduced to, say, 2 characters)

fet_begingroup ("accidentals");
  input feta-arrow;
  input feta-sharps;
  input feta-naturals;
  input feta-flats;
  input feta-parenthesis;
fet_endgroup ("accidentals");

But, in contrast to that, most of the times, there was no fet_begingroup [...] fet_endgroup indent at all, e.g.:

mf/feta-pedals.mf (current)

[...]
fet_begingroup ("pedal");

pedalpha = 40;
pedbeta = 25;
[...]

mf/feta-pedals.mf (new)

[...]
fet_begingroup ("pedal");

  pedalpha = 40;
  pedbeta = 25;
[...]

Scope

Out of the currentyl 201 *.mf files, 59 do not have any indentation and thus need not be changed.
The remaining 43 files will be re-formatted on semi-automatic.

Adapt Contributor's guide METAFONT fomatting rules

The 13.6 METAFONT formatting rules still mention tabs. This should be changed and adapted, depending on the design descision taken and implemented here.

Decision: 2 char indent

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto