[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5870 Define S

From:

Auto mailings of changes to Lily Issues via Testlilyissues-auto

Subject:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5870 Define Scheme markups using define-public

Date:

Sun, 29 Mar 2020 13:53:05 -0000

retain existing

https://codereview.appspot.com/577720043

[issues:#5870] Define Scheme markups using define-public

Status: Started
Created: Sun Mar 29, 2020 12:02 AM UTC by Han-Wen Nienhuys
Last Updated: Sun Mar 29, 2020 01:52 PM UTC
Owner: Han-Wen Nienhuys

Previously, define-markup-command[-list] would call module-define! on
(current-module). This is at odds with the GUILE 2.x precompilation,
as the side effect of module-define! is not serialized into the
compiled file.

Trim the is-list argument from define-markup-command-internal.

The define-markup-command-internal (which uses module-define) is
retained, because the parser uses it for defining markups.

Remove the undocumented and untested functionality to do

(define-markup-command a b)
(define-markup-command a (markup-lambda ..))

Because define-markup-command now reduces to a (define .. ) call, it
must happen at toplevel. This is a minor incompatible change.

Makes the function make-markup public

https://codereview.appspot.com/577720043

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.