[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5899 Setting

From:

Auto mailings of changes to Lily Issues via Testlilyissues-auto

Subject:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5899 Setting SystemStart-grob style to 'brace mostly fails

Date:

Sat, 18 Apr 2020 11:14:14 -0000

pushed to staging as:

commit 73b0006674833d0cb4a9cad8f4b27b22f786a49d (HEAD -> dev/fix-brace-font, origin/staging)
Author: Thomas Morley address@hidden
Date: Mon Apr 13 20:48:51 2020 +0200

Reword comment in lily/system-start-delimiter.cc

commit 589e73e51eccf9ac965b538d90adbf187e165037
Author: Thomas Morley address@hidden
Date: Mon Apr 13 10:31:17 2020 +0200

Revert "Load only the default font for System_start_delimiter"

This reverts commit 430bad24a2d15ec6600e0e780348a0caff29799b.

commit b20c38b0c1bcc14078f5f6b71b6627e572d31806
Author: Thomas Morley address@hidden
Date: Mon Apr 13 12:48:00 2020 +0200

Regtest for setting SystemStartGrob.style to 'brace

Checks whether the SystemStartBrace is printed

[issues:#5899] Setting SystemStart-grob style to 'brace mostly fails

Status: Started
Created: Mon Apr 13, 2020 09:25 AM UTC by Thomas Morley
Last Updated: Fri Apr 17, 2020 08:11 AM UTC
Owner: Thomas Morley
Attachments:

system-start-brace-after-patch.png (26.3 kB; image/png)
system-start-brace-fail.png (25.8 kB; image/png)

https://codereview.appspot.com/557670043/

If StaffGroup.systemStartDelimiter is set to SystemStartBracket (default), SystemStartBrace, SystemStartSquare or SystemStartBar and the SystemStartGrob.style is set 'brace. Then SystemStartBraces are not printed, except if systemStartDelimiter is SystemStartBrace anyway.

Testcode:

\version "2.20.0"

\layout {
  \context {
    \StaffGroup
    \override SystemStartBar.style = #'brace
    \override SystemStartBrace.style = #'brace
    \override SystemStartBracket.style = #'brace
    \override SystemStartSquare.style = #'brace
  }
}

<<
  $@(map
     (lambda (sym)
       #{ \new StaffGroup \with { systemStartDelimiter = #sym } << b1 b1 >> #})
     '(SystemStartBracket SystemStartBrace SystemStartSquare SystemStartBar))

See image system-start-brace-fail.png

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.