|
From: | Auto mailings of changes to Lily Issues via Testlilyissues-auto |
Subject: | [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5920 Obviate method_finder methods |
Date: | Sun, 26 Apr 2020 14:56:36 -0000 |
Pushed to staging as
commit e6ea6688f7a7ce7ef6d73ceac2775c5a19cba861
Author: David Kastrup <address@hidden>
Date: Sun Apr 19 01:20:43 2020 +0200
Issue 5920/2: Obviate method_finder methods The inheritance of various Translator::method_finder functions was a comparatively fragile mess. Instead, now mfp_baseclass is used for figuring out the proper baseclass for a given member function pointer. That allows removing the method_finder functions from the various Translator-derived classes.
commit 380fc6c654e9720651e55b16967be9655aef29c9
Author: David Kastrup <address@hidden>
Date: Sun Apr 19 11:27:22 2020 +0200
Issue 5920/1: callback.hh: implement mfp_baseclass helper This derives the corresponding base class of member function pointers in a style similar to the standard header <type_trait>. Also adds convenience macros MFP0_WRAP, MFP1_WRAP, MFP2_WRAP for wrapping member function pointers into SCM-callable closures. MFP_ARGS converts a member function pointer into the required template arguments for callbacks (base class type and member function pointer). MFP_CREATE creates a member function pointer from a base class pointer and the name of a member function. ly_remove_pointer is provided as a stand-in for <type_traits>' std::remove_pointer since the definition is near-trivial and it is used here a few times.
[issues:#5920] Obviate method_finder methods
Status: Fixed
Labels: Fixed_2_21_1
Created: Sun Apr 19, 2020 01:10 AM UTC by David Kastrup
Last Updated: Sun Apr 26, 2020 08:41 AM UTC
Owner: David Kastrup
Obviate method_finder methods
The inheritance of various Translator::method_finder functions was a
comparatively fragile mess. A helper class mfp_baseclass is able to
figure out the proper baseclass for a given member function pointer.
That allows removing the method_finder functions from the various
Translator-derived classes.
http://codereview.appspot.com/551780043
Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
_______________________________________________ Testlilyissues-auto mailing list address@hidden https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Prev in Thread] | Current Thread | [Next in Thread] |