[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5882 Refactor get/set_property to take the item as first argument

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

• labels: --> Fixed_2_21_2
• status: Started --> Fixed
• Patch: push -->
• Comment:

commit 550d0a4def00786bf7c7373101dced4c68ad893d
Merge: eeea9423b2 42eaa5cb51
Author:     David Kastrup <address@hidden>
AuthorDate: Thu Apr 30 14:24:06 2020 +0200
Commit:     David Kastrup <address@hidden>
CommitDate: Thu Apr 30 14:24:06 2020 +0200

    Merge branch 'issue5882'

commit 42eaa5cb512a55451f7769d2880d304df92abe17
Author:     David Kastrup <address@hidden>
AuthorDate: Tue Apr 7 10:48:24 2020 +0200
Commit:     David Kastrup <address@hidden>
CommitDate: Thu Apr 30 14:19:17 2020 +0200

    Issue 5882/3: Complete the set/get_property style conversion

    This fixes oversights by the automated script and actually changes the
    involved macros.  Functionally, there is no difference yet.

commit f06ee21d901a0025e4344898b2f8fb2010879abd
Author:     David Kastrup <address@hidden>
AuthorDate: Tue Apr 7 14:40:03 2020 +0200
Commit:     David Kastrup <address@hidden>
CommitDate: Thu Apr 30 14:19:17 2020 +0200

    Issue 5882/2: Run script for get/set_property refactor

    In order to allow for type-dependent speedups,
    xxx->get_property ("prop") is converted to get_property (xxx, "prop").

    [...]

commit c6c00dfcbefe265b47ef8a238c918bec88460af4
Author:     David Kastrup <address@hidden>
AuthorDate: Tue Apr 7 14:38:56 2020 +0200
Commit:     David Kastrup <address@hidden>
CommitDate: Thu Apr 30 14:19:17 2020 +0200

    Issue 5882/1: Grob::flush_extent_cache: refactor del_property call

---

[issues:#5882] Refactor get/set_property to take the item as first argument

Status: Fixed
Labels: Fixed_2_21_2
Created: Tue Apr 07, 2020 02:14 PM UTC by David Kastrup
Last Updated: Thu Apr 30, 2020 07:29 AM UTC
Owner: David Kastrup

Refactor get/set_property to take the item as first argument

This makes it possible in a future revision to make type-dependent
optimisations using memoisation techniques that cannot be factored
into member functions.

This consists of three commits, separately entered into the review so
that the humongous mechanical change in the middle commit can be
reviewed separately from the manual commits.

Commits are:

Issue 5882/1: Grob::flush_extent_cache: refactor del_property call

Issue 5882/2: Run script for get/set_property refactor

In order to allow for type-dependent speedups,
xxx->get_property ("prop") is converted to get_property (xxx, "prop").

The bulk of the work is done mechanically using the sed script

sed -i -n '1h
           1!H
           ${x
             s/\([a-z_A-Z][a-z_A-Z0-9]*\s*\(->\s*[a-z_A-Z][a-zA-Z_0-9]*\s*\|\.\s*[a-z_A-Z][a-zA-Z_0-9]*\s*\|\[[^]]*\]\s*\|([^()]*)\s*\|<[a-zA-Z_]\+>\s*\)*\)->\s*\(set_property\|get_property\|get_property_data\|get_object\|set_object\|get_pure_property\|get_maybe_pure_property\|del_property\)\(\s\+(\)/\3\4\1, /g
             s/\(set_property\|get_property\|get_property_data\|get_object\|set_object\|get_pure_property\|get_maybe_pure_property\|del_property\)\(\s\+(\)"/\1\2this, "/g
             p}' $(git ls-files '*.cc' '*.ll' '*.yy')

Issue 5882/3: Complete the set/get_property style conversion

This fixes oversights by the automated script and actually changes the
involved macros.  Functionally, there is no difference yet.

http://codereview.appspot.com/573670043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto