[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5938 Thread s

From:

Auto mailings of changes to Lily Issues via Testlilyissues-auto

Subject:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5938 Thread skyline construction through stencil interpretation

Date:

Sat, 02 May 2020 09:52:43 -0000

labels: --> Fixed_2_21_2
status: Started --> Fixed
Patch: push -->
Comment:

commit 267e894e79fe5ce238c4db40f2a760511eead001
Author:     Han-Wen Nienhuys &lt;hanwen@lilypond.org&gt;
AuthorDate: Sat Apr 25 12:10:59 2020 +0200
Commit:     Han-Wen Nienhuys &lt;hanwen@lilypond.org&gt;
CommitDate: Sat May 2 09:26:21 2020 +0200

    Thread skyline construction through stencil interpretation

[issues:#5938] Thread skyline construction through stencil interpretation

Status: Fixed
Labels: Fixed_2_21_2
Created: Sat Apr 25, 2020 11:42 AM UTC by Han-Wen Nienhuys
Last Updated: Sat May 02, 2020 05:09 AM UTC
Owner: Han-Wen Nienhuys

Before, we'd convert stencils to a combination of boxes and buildings,
and afterwards convert those to skylines.

The new approach has the following advantages:

We can convert stencils to line segments directly, allowing for more
precise outlines, and reduced memory overhead
We can treat line thicknesses much more simply: we just extend line
segments by 0.5 thicknesses on either side, and add them .5
thickness up and down.

A next improvement is to thread Lazy_skyline_pair through to the glyph
outline generation. This would let us cut back on memory use for path
storage, and reduce the number of paths by 2x (the orientation of the
outline segments tells us if they are for the up or down skyline.)

Formatting impact:

The regtest shows 114 differences. The improved skylines lead to
slightly denser formatting, both horizontally and vertically. In
particular, some accidental configurations become very cramped (eg
accidental-placement.ly)

Timing impact: TODO

https://codereview.appspot.com/581960043

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

[Prev in Thread]

Current Thread

[Next in Thread]