|
| From: | Auto mailings of changes to Lily Issues via Testlilyissues-auto |
| Subject: | [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5962 Avoid using Skyline_pair::insert. |
| Date: | Fri, 08 May 2020 13:05:29 -0000 |
commit b872b327c471a9538d93fba21ff0385709aae2c2 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sun May 3 20:31:10 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Fri May 8 09:14:55 2020 +0200 Avoid using Skyline_pair::insert. Skyline::insert(Box) creates a skyline and merges it. In this case, the boxes are non-overlapping, so it is trivial to create a skyline out of them. Remove Skyline::insert(). Using it repeatedly leads to a quadratic complexity, so it's best avoided. Timing benchmarks are neutral
[issues:#5962] Avoid using Skyline_pair::insert.
Status: Fixed
Labels: Fixed_2_21_2
Created: Sun May 03, 2020 06:55 PM UTC by Han-Wen Nienhuys
Last Updated: Thu May 07, 2020 08:49 AM UTC
Owner: Han-Wen Nienhuys
Skyline::insert(Box) creates a skyline and merges it. In this case,
the boxes are non-overlapping, so it is trivial to create a skyline
out of them.
Remove Skyline::insert(). Using it repeatedly leads to a quadratic
complexity, so it's best avoided.
Timing benchmarks are neutral
https://codereview.appspot.com/554000043
Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
_______________________________________________ Testlilyissues-auto mailing list address@hidden https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
| [Prev in Thread] | Current Thread | [Next in Thread] |