[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: SVG backend: Output a single SVG file for each page
From: |
Patrick McCarty |
Subject: |
Re: SVG backend: Output a single SVG file for each page |
Date: |
Fri, 7 Aug 2009 17:38:12 -0700 |
On Fri, Aug 7, 2009 at 4:56 PM, <address@hidden> wrote:
> lgtm. You can ignore my nitpicking if you disagree.
>
>
> http://codereview.appspot.com/105045/diff/5/1005
> File scm/framework-svg.scm (right):
>
> http://codereview.appspot.com/105045/diff/5/1005#newcode60
> Line 60: (dump (ec 'svg))
> Just a very very minor thing: IWBN to have eo and ec closer together.
> For example, if svg-header just returned the alist of attributes then
> you could write
> (dump (eo (cons 'svg (svg-header paper)))
> ...
> (dump (ec 'svg))
> and it would be totally obvious that they match.
Thanks, Joe. I'll implement your suggestion and then push.
-Patrick