[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Unsecure assoc calls
From: |
Neil Puttock |
Subject: |
Re: Unsecure assoc calls |
Date: |
Fri, 11 Sep 2009 20:34:24 +0100 |
2009/9/11 Michael Käppler <address@hidden>:
> Attached is the revised version. Okay to apply?
There are a few problems with this:
You need to amend the definition of the method in lily-guile.hh, since
it's also used directly in the C++ code, with no optional arguments:
53 SCM ly_assoc_get (SCM key, SCM alist, SCM def);
+ programming_error ("Cannot find key ~S in alist, setting to ~S.",
ly_scm2string (key), ly_scm2string (default_value));
I think what Carl is getting at here is that you can't pass these
string values using format with programming_error () without adding
the macro `(_f', but this shouldn't be used in this case since it
internationalizes the message.
There's a bigger problem here though, since it's not clear what the
value of the key is going to be before converting it: ly_scm2string
will only work if the scheme value is a string. This naturally
applies to default_value too, which could conceivably be any scheme
object.
Regards,
Neil
- Unsecure assoc calls (was: Make default margin values depend on paper size), Michael Käppler, 2009/09/11
- Re: Unsecure assoc calls (was: Make default margin values depend on paper size), Carl Sorensen, 2009/09/11
- Re: Unsecure assoc calls, Michael Käppler, 2009/09/11
- Re: Unsecure assoc calls,
Neil Puttock <=
- Re: Unsecure assoc calls, Michael Käppler, 2009/09/11
- Re: Unsecure assoc calls, Carl Sorensen, 2009/09/11
- Re: Unsecure assoc calls, Michael Käppler, 2009/09/12
- Re: Unsecure assoc calls, Neil Puttock, 2009/09/12
- Re: Unsecure assoc calls, Michael Käppler, 2009/09/12
- Re: Unsecure assoc calls, Neil Puttock, 2009/09/12
- Re: Unsecure assoc calls, Neil Puttock, 2009/09/12
- Re: Unsecure assoc calls, Michael Käppler, 2009/09/13
- Re: Unsecure assoc calls, Carl Sorensen, 2009/09/13
- Re: Unsecure assoc calls, John Mandereau, 2009/09/13