Re: Allows users to prevent rests from automatically shifting. (issue4385053)

[Carl . D . Sorensen]

Wow -- what a quick response!  Thanks!

I have a couple of comments.

Carl



http://codereview.appspot.com/4385053/diff/1/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/4385053/diff/1/scm/define-grob-properties.scm#newcode61
scm/define-grob-properties.scm:61: (automatic-shift ,boolean? "Should a
rest be automatically shifted?")
Since this applies to both MMRest and Percent Repeat, should it say
"rest"?

Also, I think it should have a statement that defines the kind of shift
we're talking about, if possible.

http://codereview.appspot.com/4385053/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (right):

http://codereview.appspot.com/4385053/diff/1/scm/define-grobs.scm#newcode1545
scm/define-grobs.scm:1545: (automatic-shift . #t)
You've added this property to the PercentRepeat grob, but I don't see
where the engraver has been changed.

http://codereview.appspot.com/4385053/