[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix determine-frets so that it preserves note order (issue4518045)
From: |
Carl . D . Sorensen |
Subject: |
Re: Fix determine-frets so that it preserves note order (issue4518045) |
Date: |
Thu, 26 May 2011 03:36:08 +0000 |
On 2011/05/26 03:26:32, Keith wrote:
`make check` was crashing on an unbound variable 'note'. Given line
345 above
the fix was so obvious that I just pushed it.
Thanks for the fix. I had found that fix as well, and was getting ready
to push it. But there's still another problem. Right now 'ignore has
the same effect as 'recalculate, and it shouldn't.
So this patch fixes compiling, but not the regtest.
Thanks,
Carl
http://codereview.appspot.com/4518045/