[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bugfix for issue 1630 (issue4490045)
From: |
percival . music . ca |
Subject: |
Re: Bugfix for issue 1630 (issue4490045) |
Date: |
Sun, 29 May 2011 15:39:49 +0000 |
http://codereview.appspot.com/4490045/diff/12001/lily/completion-note-heads-engraver.cc
File lily/completion-note-heads-engraver.cc (right):
http://codereview.appspot.com/4490045/diff/12001/lily/completion-note-heads-engraver.cc#newcode207
lily/completion-note-heads-engraver.cc:207:
event->set_property("autosplit-end", ly_bool2scm (false));
On 2011/05/28 20:27:13, karin.hoethker wrote:
However, some people consider inline conditions not to be
very readable (for a (Java) example see AvoidInlineConditionals at
http://checkstyle.sourceforge.net/config_coding.html). Although this
is not an
extreme case, I'd rather vote for readability and leave the code as it
is.
FWIW, I prefer Karin's formulation:
if (blah) func(true); else func(false);
However, David and Pal combined have at least 10 times as much
experience with lilypond C++ code as I do, so I think it would be best
if this conditional were changed.
http://codereview.appspot.com/4490045/
- Re: Bugfix for issue 1630 (issue4490045), (continued)
- Re: Bugfix for issue 1630 (issue4490045), percival . music . ca, 2011/05/26
- Re: Bugfix for issue 1630 (issue4490045), lemniskata . bernoullego, 2011/05/29
- Re: Bugfix for issue 1630 (issue4490045), benko . pal, 2011/05/29
- Re: Bugfix for issue 1630 (issue4490045), Carl . D . Sorensen, 2011/05/29
- Re: Bugfix for issue 1630 (issue4490045), karin . hoethker, 2011/05/29
- Re: Bugfix for issue 1630 (issue4490045), Carl . D . Sorensen, 2011/05/29
- Re: Bugfix for issue 1630 (issue4490045), karin . hoethker, 2011/05/29
- Re: Bugfix for issue 1630 (issue4490045),
percival . music . ca <=
- Re: Bugfix for issue 1630 (issue4490045), lemniskata . bernoullego, 2011/05/30
- Re: Bugfix for issue 1630 (issue4490045), Carl . D . Sorensen, 2011/05/30
- Re: Bugfix for issue 1630 (issue4490045), benko . pal, 2011/05/30