[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: modifying default behaviour of tremolo slashes (issue4636081)
From: |
lemniskata . bernoullego |
Subject: |
Re: modifying default behaviour of tremolo slashes (issue4636081) |
Date: |
Sat, 23 Jul 2011 19:58:19 +0000 |
New patch set uploaded. Current Lily default behaviour is kept as
default now.
http://codereview.appspot.com/4636081/diff/10001/lily/stem-tremolo.cc
File lily/stem-tremolo.cc (right):
http://codereview.appspot.com/4636081/diff/10001/lily/stem-tremolo.cc#newcode42
lily/stem-tremolo.cc:42: style = ly_symbol2scm ("constant");
On 2011/07/21 08:39:53, joeneeman wrote:
You can remove these two lines and use
style == ly_symbol2scm ("varying")
below
Done.
http://codereview.appspot.com/4636081/diff/10001/lily/stem-tremolo.cc#newcode93
lily/stem-tremolo.cc:93: style = ly_symbol2scm ("constant");
On 2011/07/21 08:39:53, joeneeman wrote:
These two lines are redundant.
Isn't their purpose to guard against undefined (empty) style property?
http://codereview.appspot.com/4636081/
- Re: modifying default behaviour of tremolo slashes (issue4636081), (continued)
- Re: modifying default behaviour of tremolo slashes (issue4636081), pkx166h, 2011/07/19
- Re: modifying default behaviour of tremolo slashes (issue4636081), joeneeman, 2011/07/21
- Re: modifying default behaviour of tremolo slashes (issue4636081),
lemniskata . bernoullego <=
- Re: modifying default behaviour of tremolo slashes (issue4636081), joeneeman, 2011/07/24
- Re: modifying default behaviour of tremolo slashes (issue4636081), pkx166h, 2011/07/24
- Re: modifying default behaviour of tremolo slashes (issue4636081), lemniskata . bernoullego, 2011/07/24
- Re: modifying default behaviour of tremolo slashes (issue4636081), lemniskata . bernoullego, 2011/07/29
- Re: modifying default behaviour of tremolo slashes (issue4636081), lemniskata . bernoullego, 2011/07/29
- Re: modifying default behaviour of tremolo slashes (issue4636081), pkx166h, 2011/07/30