|
From: | hanwenn |
Subject: | Re: Proper loglevels: cmd-line option --loglevel=NONE/ERROR/WARN/PROGRESS/INFO/DEBUG (issue4822055) |
Date: | Sat, 30 Jul 2011 16:28:32 +0000 |
overall commment: the parts that do the reporting should not need to know about the format of loglevel. I think it would be better to have a if (log(ERROR)) { .. } or perhaps even log(ERROR, "...") rather than having each bit do the bitmasking separately like in this patch. http://codereview.appspot.com/4822055/
[Prev in Thread] | Current Thread | [Next in Thread] |