|
From: | Jean-Charles Malahieude |
Subject: | Re: Final redirection of texi output (issue 5650064) |
Date: | Mon, 13 Feb 2012 19:18:55 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux i686; rv:10.0) Gecko/20120131 Thunderbird/10.0 |
Le 13/02/2012 14:56, address@hidden disait :
Looks good, I just have a few suggestions to avoid clashing log file names and I wonder how this part of GOP 9 might be implemented down the road: "All other logfiles will go in the @file{build/logfiles/} directory." http://codereview.appspot.com/5650064/diff/5003/make/doc-i18n-root-rules.make#newcode10 make/doc-i18n-root-rules.make:10: $(buildscript-dir)/run-and-check "DEPTH=$(depth)/../ $(TEXI2HTML) $(TEXI2HTML_SPLIT) $(TEXI2HTML_FLAGS) --output=$(outdir)/$* $<" "$*.splittexi.log" I suggest adding $(ISOLANG) to the name of the log files generated from this Makefile, eg: $*.$(ISOLANG).splittexi.log
Too bad ! I'm now used to see MANUAL.bigtexi.log and MANUAL.splittexi.log directly in Documentation/ISOLANG/
Very useful by the way for checking bad x-refs (size > 0 means something is wrong, except for web which normally contains a single line: "Processing web site: [ISOLANG]")
THANKS for this. Cheers, Jean-Charles
[Prev in Thread] | Current Thread | [Next in Thread] |