Re: Issue 4024: Clarify break-align symbols and space-alist args in IR. (issue 114160044 by address@hidden)

[markpolesky]

On 2014/07/29 05:35:40, Keith wrote:

https://codereview.appspot.com/114160044/diff/1/scm/define-grob-properties.scm#newcode902
> scm/define-grob-properties.scm:902: @code{right-edge}; otherwise it is
fixed.
> Looking at the code, 'right-edge' would seem to be among the
"otherwise it is
> fixed" cases.  If you found differently by experiment, then experiment
rules.

You are correct.  Done.


https://codereview.appspot.com/114160044/diff/1/scm/define-grob-properties.scm#newcode905
> scm/define-grob-properties.scm:905: Put at least this much space
between the
> left side of both grobs,
> "left sides"

Done.


https://codereview.appspot.com/114160044/diff/1/scm/define-grob-properties.scm#newcode911
> scm/define-grob-properties.scm:911: Only use with @code{first-note},
> @code{next-note}, and @code{right-edge}.
> "Only effective"  communicates more information.  "Only use" makes me
wonder "or
> else what?"

I decided to use "only compatible with", since technically some
combinations are "effective" even though they weren't intended to be
(see below).


https://codereview.appspot.com/114160044/diff/1/scm/define-grob-properties.scm#newcode917
> scm/define-grob-properties.scm:917: the note (or edge), without
allowing them to
> collide.
> Again, I don't see 'right-edge' in the cases that read
minimum-fixed-space, nor
> semi-fixed-space.

Ah, I see.  Here's the confusion: when paired with right-edge, *all* 5
of the spacing-styles actually do something (to be clear, they all do
the same thing: they behave like extra-space, with space that doesn't
stretch).  Anyway, am I correct in concluding that right-edge is only
intended to work with extra-space?  I've edited the patch according to
that understanding; please review and comment again if you would.

For some reason Rietveld doesn't show the deltas from the previous patch
set (maybe because I rebased?), so you'll just have to read it again.
The only changes are in lines 891-926 here:
http://codereview.appspot.com/114160044/diff/60001/scm/define-grob-properties.scm#newcode869

Thanks for looking this over,
Mark

https://codereview.appspot.com/114160044/