[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Make \header blocks tangible in Scheme (issue 296600043 by address@h
From: |
thomasmorley65 |
Subject: |
Re: Make \header blocks tangible in Scheme (issue 296600043 by address@hidden) |
Date: |
Wed, 29 Jun 2016 14:56:22 -0700 |
regtest and changes LGTM
From experimenting with it, changes in parser are great.
A remark, unrelated to current patch:
https://codereview.appspot.com/296600043/diff/20001/input/regression/identifiers.ly
File input/regression/identifiers.ly (right):
https://codereview.appspot.com/296600043/diff/20001/input/regression/identifiers.ly#newcode14
input/regression/identifiers.ly:14: markupId = \markup { hoi }
markupId and stringId are not used later. Ofcourse this doesn't affect
whats tested here, but feels strange to me.
Change it while you're on it?
https://codereview.appspot.com/296600043/
- Make \header blocks tangible in Scheme (issue 296600043 by address@hidden), thomasmorley65, 2016/06/28
- Re: Make \header blocks tangible in Scheme (issue 296600043 by address@hidden), dak, 2016/06/28
- Re: Make \header blocks tangible in Scheme (issue 296600043 by address@hidden), pkx166h, 2016/06/28
- Re: Make \header blocks tangible in Scheme (issue 296600043 by address@hidden), dak, 2016/06/28
- Re: Make \header blocks tangible in Scheme (issue 296600043 by address@hidden), thomasmorley65, 2016/06/28
- Re: Make \header blocks tangible in Scheme (issue 296600043 by address@hidden),
thomasmorley65 <=
- Re: Make \header blocks tangible in Scheme (issue 296600043 by address@hidden), dak, 2016/06/30