Fix Type1 (PFA and PFB) font embedding (issue 313930043 by address@hidden)

[lemzwerg]

LGTM.


https://codereview.appspot.com/313930043/diff/1/lily/pfb.cc
File lily/pfb.cc (right):

https://codereview.appspot.com/313930043/diff/1/lily/pfb.cc#newcode49
lily/pfb.cc:49: seglen |= (static_cast<Byte>(*p++) << 24);
I suggest to add a guard against invalid, possibly extremely large
`seglen' values...

https://codereview.appspot.com/313930043/diff/1/lily/pfb.cc#newcode62
lily/pfb.cc:62: static_cast<int>(static_cast<Byte>(*p++)));
As above, we should probably add a guard against invalid data...

I also wonder whether `sprintf' is the most efficient tool for
converting two hex digits into a byte value.

https://codereview.appspot.com/313930043/