lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Add glib-2.0 and gobject-2.0 library dependency (issue 552770043 by addr


From: lemzwerg
Subject: Add glib-2.0 and gobject-2.0 library dependency (issue 552770043 by address@hidden)
Date: Mon, 03 Jun 2019 22:40:35 -0700

LGTM, with only small issues that don't deserve a new upload.  Since
Knut doesn't have time I can take care of the patch, fixing the minor
issues.


https://codereview.appspot.com/552770043/diff/574790043/aclocal.m4
File aclocal.m4 (right):

https://codereview.appspot.com/552770043/diff/574790043/aclocal.m4#newcode1291
aclocal.m4:1291: save_CPPFLAGS="$CPPFLAGS"
we probably should replace tabs with spaces ...

https://codereview.appspot.com/552770043/diff/574790043/config.make.in
File config.make.in (right):

https://codereview.appspot.com/552770043/diff/574790043/config.make.in#newcode23
config.make.in:23: CONFIG_CFLAGS = @CFLAGS@
$(GLIB_CFLAGS)$(GUILE_CFLAGS) $(FREETYPE2_CFLAGS) $(PANGO_FT2_CFLAGS)
A space is missing here.

https://codereview.appspot.com/552770043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]