Re: Doc: NR - 2.10 World Music Turkish Classical additions (issue 550780043 by address@hidden)

[pkxgnugitcl]

Reviewers: lemzwerg,


https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely
File Documentation/notation/world.itely (right):

https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode74
Documentation/notation/world.itely:74: Western staff notes are still
used, but with special accidentals unique
On 2019/05/31 07:05:12, lemzwerg wrote:
> unique → uniquely

Done.

https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode78
Documentation/notation/world.itely:78: Other, related, init files are
also available; @file{hel-arabic.ly} and
On 2019/05/31 07:05:12, lemzwerg wrote:
> Other, related, init files → Other, related init files

Done.

https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode438
Documentation/notation/world.itely:438: @q{group} of maqams than
individual key signatures for each maqam
On 2019/05/31 07:05:12, lemzwerg wrote:
> than → instead of

Done.

https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode439
Documentation/notation/world.itely:439: seperately.
On 2019/05/31 07:05:12, lemzwerg wrote:
> seperately → separately

Done.

https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode505
Documentation/notation/world.itely:505: of a tone, from which are
constructed the melodic forms known as
On 2019/05/31 07:05:12, lemzwerg wrote:
> from which the melodic forms ... are constructed.

Done.

https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode521
Documentation/notation/world.itely:521: the basis of pitch on 1/9-tone
divisions means makamlar employ a
On 2019/05/31 07:05:12, lemzwerg wrote:
> means → means that

Done.

https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode522
Documentation/notation/world.itely:522: completely different set of
intervals from Western scales and modes:
On 2019/05/31 07:05:12, lemzwerg wrote:
> from → compared to

Done.

https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode560
Documentation/notation/world.itely:560: The correct accidentals koma
flat (@var{b1}) and koma sharp (@code{f4}),
On 2019/05/31 07:05:12, lemzwerg wrote:
> accidentals, ... (...), ...

Done.

https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode591
Documentation/notation/world.itely:591: contains information in English
regarding Turkish makam including 2 CDs.
On 2019/05/31 07:05:12, lemzwerg wrote:
> 2 → two

Done.

https://codereview.appspot.com/550780043/diff/560710043/Documentation/snippets/new/turkish-makam-example.ly
File Documentation/snippets/new/turkish-makam-example.ly (right):

https://codereview.appspot.com/550780043/diff/560710043/Documentation/snippets/new/turkish-makam-example.ly#newcode7
Documentation/snippets/new/turkish-makam-example.ly:7: Here is a
template that also uses the start of a well known Turkish
On 2019/05/31 07:05:12, lemzwerg wrote:
> Here is a template that also uses... → This template uses...

> well known → well-known

Done.

Description:
Doc: NR - 2.10 World Music Turkish Classical additions

Additions to Turkish Classical Music
From suggestions made by Adam Good
also references to Adam's recent
Turkish Makam additions.

Removed @lilypond example and
made it a snippet.

Formatted changed sections so
they follow more closely to the
CG Guidelines.

Removed the table listing some
of the modes and referenced the
Turkish Makam ly file instead as
it has significantly more additions.

Please review this at https://codereview.appspot.com/550780043/

Affected files (+164, -125 lines):
  M Documentation/notation/world.itely
  A Documentation/snippets/new/turkish-makam-example.ly