[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Add glib-2.0 and gobject-2.0 library dependency (issue 568820043 by
|
From: |
knupero |
|
Subject: |
Re: Add glib-2.0 and gobject-2.0 library dependency (issue 568820043 by address@hidden) |
|
Date: |
Mon, 17 Jun 2019 00:59:41 -0700 |
See individual comments ...
https://codereview.appspot.com/568820043/diff/582790043/config.make.in
File config.make.in (right):
https://codereview.appspot.com/568820043/diff/582790043/config.make.in#newcode23
config.make.in:23: CONFIG_CFLAGS = @CFLAGS@ $(GLIB_CFLAGS)
$(GUILE_CFLAGS)
This breaks building.
If you break lines, you need to use ' \'
https://codereview.appspot.com/568820043/diff/582790043/config.make.in#newcode25
config.make.in:25: CONFIG_CXXFLAGS = @CXXFLAGS@ $(GUILE_CFLAGS)
$(FREETYPE2_CFLAGS)
see above
https://codereview.appspot.com/568820043/diff/582790043/config.make.in#newcode36
config.make.in:36: CONFIG_LIBS = @LIBS@ @EXTRA_LIBS@ $(GLIB_LIBS)
$(GUILE_LIBS)
see above
https://codereview.appspot.com/568820043/diff/582790043/config.make.in#newcode37
config.make.in:37: $(PANGO_FT2_LIBS) $(FONTCONFIG_LIBS)
see above
https://codereview.appspot.com/568820043/diff/582790043/configure.ac
File configure.ac (right):
https://codereview.appspot.com/568820043/diff/582790043/configure.ac#newcode301
configure.ac:301: STEPMAKE_GLIB(glib-2.0, REQUIRED, 2.44)
A gub build revealed that we use glib 2.38 for freebsd cross builds.
'2.44' must be changed to '2.38'
https://codereview.appspot.com/568820043/diff/582790043/configure.ac#newcode302
configure.ac:302: STEPMAKE_GOBJECT(gobject-2.0, REQUIRED, 2.44)
Same as above, change '2.44' to '2.38'
https://codereview.appspot.com/568820043/