[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Let flex handle the input stack (issue 563560043 by address@hidden)
From: |
jonas . hahnfeld |
Subject: |
Re: Let flex handle the input stack (issue 563560043 by address@hidden) |
Date: |
Fri, 21 Feb 2020 00:00:27 -0800 |
https://codereview.appspot.com/563560043/diff/567260043/aclocal.m4
File aclocal.m4 (right):
https://codereview.appspot.com/563560043/diff/567260043/aclocal.m4#newcode556
aclocal.m4:556: # check for yyFlexLexer.yypop_buffer_state () since flex
2.5.29
On 2020/02/20 23:05:46, hanwenn wrote:
> On 2020/02/20 14:21:08, hahnjo wrote:
> > Random thought: Do we want to check for features introduced in 2003
or can we
> > just assume that we never come across ancient versions that don't
support
> this?
>
> could we check the version number instead?
No, the header doesn't have version information. Moreover I think
checking for functionality is actually better than checking a random
version number because it actually documents what we need.
As I've already adapted the existing test below, I think we can also
leave it for now. The only advantage of deleting them would be to have
less lines ;-)
https://codereview.appspot.com/563560043/