|
| From: | lemzwerg |
| Subject: | Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by address@hidden) |
| Date: | Mon, 30 Mar 2020 09:06:07 -0700 |
Nice idea, thanks. Some nits and questions. https://codereview.appspot.com/557640051/diff/571940043/Documentation/notation/text.itely File Documentation/notation/text.itely (right): https://codereview.appspot.com/557640051/diff/571940043/Documentation/notation/text.itely#newcode1552 Documentation/notation/text.itely:1552: (and thus available in LilyPond scores), through the following commands: no comma https://codereview.appspot.com/557640051/diff/571940043/Documentation/notation/text.itely#newcode1558 Documentation/notation/text.itely:1558: I would remove this empty line in the @example environment. https://codereview.appspot.com/557640051/diff/571940043/input/regression/font-name-add-files.ly File input/regression/font-name-add-files.ly (right): https://codereview.appspot.com/557640051/diff/571940043/input/regression/font-name-add-files.ly#newcode14 input/regression/font-name-add-files.ly:14: dummyfontfile = #(string-append (tmpnam) "-dummyfont.otf") s/ / / https://codereview.appspot.com/557640051/diff/571940043/input/regression/font-name-add-files.ly#newcode210 input/regression/font-name-add-files.ly:210: #(mkdir dummyfontdir) Is it guaranteed that we can create this directory? What about srcdir != builddir? https://codereview.appspot.com/557640051/
| [Prev in Thread] | Current Thread | [Next in Thread] |