|
| From: | hanwenn |
| Subject: | Re: Abstract Grob property storage into Mutable_properties. (issue 561640043 by address@hidden) |
| Date: | Mon, 13 Apr 2020 13:31:05 -0700 |
https://codereview.appspot.com/561640043/diff/565900043/lily/include/mutable-properties.hh
File lily/include/mutable-properties.hh (right):
https://codereview.appspot.com/561640043/diff/565900043/lily/include/mutable-properties.hh#newcode54
lily/include/mutable-properties.hh:54: Iterator iter() const {
On 2020/04/13 17:15:19, Dan Eble wrote:
> Does const serve a purpose here? The iterator doesn't carry through
with any
> kind of enforcement. The same question applies to try_retrieve() and
> to_alist().
It allows one to iterate over properties in a const method.
What kind of enforcement are you looking for?
https://codereview.appspot.com/561640043/diff/565900043/lily/include/mutable-properties.hh#newcode60
lily/include/mutable-properties.hh:60: void swap(Mutable_properties*);
On 2020/04/13 17:15:19, Dan Eble wrote:
> Please: void swap(Mutable_properties&) like everything in the STL.
Done.
https://codereview.appspot.com/561640043/
| [Prev in Thread] | Current Thread | [Next in Thread] |