|
| From: | hanwenn |
| Subject: | Re: Use a hash table for the lexer keywords (issue 549920043 by address@hidden) |
| Date: | Mon, 20 Apr 2020 01:34:06 -0700 |
https://codereview.appspot.com/549920043/diff/553940043/lily/include/lily-lexer.hh File lily/include/lily-lexer.hh (right): https://codereview.appspot.com/549920043/diff/553940043/lily/include/lily-lexer.hh#newcode23 lily/include/lily-lexer.hh:23: #include <unordered_map> On 2020/04/20 08:17:05, hahnjo wrote: > Please put C++ includes last. I know that Google advocates differently, but > having them first makes it very easy to rely on that in other header files. > Instead every header file should include what they use. Done. https://codereview.appspot.com/549920043/
| [Prev in Thread] | Current Thread | [Next in Thread] |