lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Obviate method_finder methods (issue 551780043 by address@hidden)


From: dak
Subject: Re: Obviate method_finder methods (issue 551780043 by address@hidden)
Date: Mon, 20 Apr 2020 17:43:02 -0700

On 2020/04/20 23:26:07, Dan Eble wrote:
> On 2020/04/20 19:36:39, dak wrote:
> > Polish and extend tools in callback.hh
> 
> LGTM.
> 
> I have a hunch that the MFPn_WRAP macros could be turned into
something more
> typical of C++, but I don't blame you for resting at this point.

Not without a lot of effort since MFP1_WRAP and MFP2_WRAP rely on
"trampoline" in the current lexical scope doing something sensible. 
They are unclean macros.  So one would have to overhaul the whole
trampoline concept to collect all trampolines in one scope (either :: or
Callback?::) and scatter specialisations over the files that want them. 
A lot of work for what does not really look like a whole lot of gain.

https://codereview.appspot.com/551780043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]