lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix font-name-add-files.ly on GUILE v2 (issue 567500043 by address@h


From: hanwenn
Subject: Re: Fix font-name-add-files.ly on GUILE v2 (issue 567500043 by address@hidden)
Date: Sat, 25 Apr 2020 03:53:22 -0700

Reviewers: Valentin Villenave,

Message:
On 2020/04/25 09:01:49, Valentin Villenave wrote:
> Thanks, this should be pushed immediately I think.
> 
> (Man, did this regtest give us a lot of headaches.)
> 
>
https://codereview.appspot.com/567500043/diff/577810043/input/regression/font-name-add-files.ly
> File input/regression/font-name-add-files.ly (right):
> 
>
https://codereview.appspot.com/567500043/diff/577810043/input/regression/font-name-add-files.ly#newcode222
> input/regression/font-name-add-files.ly:222: (if (guile-v2)
(set-port-encoding!
> port "ISO-8859-1"))
> This didn’t trigger any errors on my Guile2.2 build, but thanks for
catching it
> anyway.

I think the default encoding of ports may depend on environment
variables for language settings.

Description:
Fix font-name-add-files.ly on GUILE v2

Please review this at https://codereview.appspot.com/567500043/

Affected files (+1, -0 lines):
  M input/regression/font-name-add-files.ly


Index: input/regression/font-name-add-files.ly
diff --git a/input/regression/font-name-add-files.ly 
b/input/regression/font-name-add-files.ly
index 
1519e60ffef3266711ebb8c0262c1b1c46bec340..c6027597ffb5a66920b84d9e9d4a5be9c2a0f53b
 100644
--- a/input/regression/font-name-add-files.ly
+++ b/input/regression/font-name-add-files.ly
@@ -219,6 +219,7 @@ DQAAAAEAAAAA2m42gAAAAADapnDnAAAAANqnrLQFlwAyBZcARQ==
 \book {
 
 #(let* ((port (open-output-file dummyfontfile)))
+  (if (guile-v2) (set-port-encoding! port "ISO-8859-1"))
   (base64-decode port dummyfont)
   (close port))
 





reply via email to

[Prev in Thread] Current Thread [Next in Thread]